[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21372: [PATCH v4] df: fix prioritize real mounts over bind mounts
From: |
Pádraig Brady |
Subject: |
bug#21372: [PATCH v4] df: fix prioritize real mounts over bind mounts |
Date: |
Tue, 22 Sep 2015 23:47:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 22/09/15 23:28, Dave Chiluk wrote:
> The patch I just sent out broke existing behavior on non-linux again.
> I'm really beginning to hate that if statement. Anyhow, I fixed that,
> and changed it around for readability.
bool target_nearer_device_root = ! (devlist->me->me_mntroot != NULL
&& me->me_mntroot != NULL
&& (strlen (devlist->me->me_mntroot)
< strlen(me->me_mntroot)));
While this is logically correct it's confusing
as mntroot is related to the source, not the target.
Also the >= implicit in the !< conflicts with "nearer",
where "as_near_or_nearer" would be more accurate.
That's why I kept the ! outside of the boolean.
I'll go with my orig naming unless there are major objections.
thanks,
Pádraig.
- bug#21372: [PATCH] df: fix prioritize real mounts over bind mounts, Pádraig Brady, 2015/09/11
- bug#21372: [PATCH] df: fix prioritize real mounts over bind mounts, Dave Chiluk, 2015/09/11
- bug#21372: [PATCH] df: fix prioritize real mounts over bind mounts, Pádraig Brady, 2015/09/11
- bug#21372: [PATCH v4] df: fix prioritize real mounts over bind mounts, Dave Chiluk, 2015/09/21
- bug#21372: [PATCH v4] df: fix prioritize real mounts over bind mounts, Pádraig Brady, 2015/09/21
- bug#21372: [PATCH v4] df: fix prioritize real mounts over bind mounts, Pádraig Brady, 2015/09/21
- bug#21372: [PATCH v4] df: fix prioritize real mounts over bind mounts, Dave Chiluk, 2015/09/22
- bug#21372: [PATCH v4] df: fix prioritize real mounts over bind mounts, Dave Chiluk, 2015/09/22
- bug#21372: [PATCH v4] df: fix prioritize real mounts over bind mounts,
Pádraig Brady <=
- bug#21372: [PATCH v4] df: fix prioritize real mounts over bind mounts, Dave Chiluk, 2015/09/23