[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#15173: [PATCH] cp: with --link always use linkat() if available

From: Bernhard Voelker
Subject: bug#15173: [PATCH] cp: with --link always use linkat() if available
Date: Fri, 13 Dec 2013 01:51:32 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5

On 12/13/2013 12:11 AM, Pádraig Brady wrote:
> So while the above patch is probably correct, it's slightly risky
> at this stage before a release.  Also the benefits are minimal as
> the existing symlink to symlink emulation should be fine on the mentioned 
> systems.
> Therefore I'll go with the attached patch which fixes the test to run
> on all platforms. The test failed on freebsd, aix and solaris previously,
> and I've confirmed it now passes on all those.

Unfortunately, I didn't have time to look into the details of this
issue.  As I understood your comment, it is not a FP in the tests but
rather an issue in copy.c on these platforms.
I'm fine with the proposed patch for the time being, i.e. to NOP out
some test cases to avoid FPs- but it then would probably make sense
to document the varying behavior, at least in a FIXME in the test.

Thanks & have a nice day,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]