[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#15819: colorls.csh errors out if "noclobber" is set (coreutils 8.21.
From: |
Pádraig Brady |
Subject: |
bug#15819: colorls.csh errors out if "noclobber" is set (coreutils 8.21.11, Fedora19) |
Date: |
Wed, 06 Nov 2013 13:21:46 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
tag 15819 notabug
close 15819
stop
On 11/06/2013 07:00 AM, Ty! Boyack wrote:
> Behavior:
>
> The setup script /etc/profile.d/colorls.csh works fine in a stock F19
> installation, but if a local admin adds a default shell setting of
> "noclobber" in a profile setting that runs before this script (as we do)
> then the script will error out with an error of:
>
> /tmp/.colorlsXXX: File exists.
>
> Cause:
>
> The script creates that temporary file with mktemp, but on the first
> write it uses only a single redirect (>), which fails when noclobber is set.
>
> Since the file is already created, I think we can safely use an append
> redirect (>>) in all cases where that file is written to, which works
> regardless of the state of the noclobber settting.
>
> Patch:
>
> 35c35
> < if ( "$INCLUDE" != '' ) cat "$INCLUDE" > $TMP
> ---
>> if ( "$INCLUDE" != '' ) cat "$INCLUDE" >> $TMP
>
> Disclaimer:
>
> I know this is not against the latest source, but I did not see anything
> in the bug lists regarding this. My apologies if this has already been
> looked at and fixed or dismissed.
"Include" support was added to the _Fedora_ ls color config files recently,
which broke things in various situations. Since this is not a upstream
issue, I'm closing it here and opened: https://bugzilla.redhat.com/1027279
thanks,
Pádraig.