[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13127: [PATCH] cut: use only one data strucutre
From: |
Pádraig Brady |
Subject: |
bug#13127: [PATCH] cut: use only one data strucutre |
Date: |
Tue, 07 May 2013 13:10:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 05/06/2013 07:54 PM, Cojocaru Alexandru wrote:
> On Mon, 29 Apr 2013 00:59:20 +0100
> Pádraig Brady <address@hidden> wrote:
>
>> So I reinstated the bit vector which was a little tricky
>> to do while maintaining performance, but it works very well.
> I think it works because we are avoiding a memory access
> inside `next_item' this way.
>
> With this patch I try to keep the CPU benefits for `--output-d'
> and when large ranges are specified, even without the bitarray.
>
> Because of the sentinel now the max line len supported will be
> `(size_t)-1 - 1' and no more `(size_t)-1'. Is this an issue?
>
> PS: This patch also fix a little bug inside `set_fields'.
It's always best to have separate changes.
I've split the fix out (attached) with an associated test.
thanks,
Pádraig.
cut-merge-fix.patch
Description: Text Data