[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13665: Question about the translation of double_to_human
From: |
Bernhard Voelker |
Subject: |
bug#13665: Question about the translation of double_to_human |
Date: |
Sun, 10 Feb 2013 18:15:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
On 02/10/2013 05:28 PM, Pádraig Brady wrote:
> I've cleaned this up in the attached so that both use the same
> method to output the messages, and both now enable these messages
> with the the same ---debug option.
> Also translations are removed from these messages,
> and a syntax check added to stop future translations sneaking in in future.
Great work, thanks.
Minor nit:
> diff --git a/cfg.mk b/cfg.mk
> index fbc64b4..09858a1 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -521,6 +521,13 @@ sc_THANKS_in_duplicates:
> && { echo '$(ME): remove the above names from THANKS.in' \
> 1>&2; exit 1; } || :
>
> +# Look for developer diagnostics that are marked for translation.
> +# This won't find any for which devmsg's format string is on a separate line.
> +sc_marked_devdiagnostics:
> + @prohibit='\<devmsg *\(.*_\(' \
> + halt='found marked developer diagnostic(s)' \
> + $(_sc_search_regexp)
> +
Shouldn't it be this pattern instead?
- @prohibit='\<devmsg *\(.*_\(' \
+ @prohibit='\<devmsg *\( *_\(' \
And: do we need to reference Goeran's message to the ML?
Other than that:
+1
Have a nice day,
Berny
Message not available