|
From: | Eric Blake |
Subject: | bug#9170: [PATCH] cp "restores" permissions it never set |
Date: | Mon, 25 Jul 2011 15:21:33 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.11 |
On 07/25/2011 03:06 PM, Paul Eggert wrote:
Thanks for the bug report. I committed this patch: +++ b/src/copy.c @@ -2211,6 +2211,8 @@ copy_internal (char const *src_name, char const *dst_name, if (x->verbose) emit_verbose (src_name, dst_name, NULL); } + else + omitted_permissions = 0;
This violates the style guide in HACKING; it should either be: if (!cond) omitted_permissions = 0; else { lots of lines } or: if (cond) { lots of lines } else { omitted_permissions = 0; } -- Eric Blake address@hidden +1-801-349-2682 Libvirt virtualization library http://libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |