bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#9077: coreutils-8.12: fiemap.h uses "struct fiemap_extent fm_extents


From: Pádraig Brady
Subject: bug#9077: coreutils-8.12: fiemap.h uses "struct fiemap_extent fm_extents[0]; "
Date: Fri, 15 Jul 2011 02:11:08 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3

On 14/07/11 23:50, Paul Eggert wrote:
> On 07/14/11 04:45, Pádraig Brady wrote:
>> The non standard "zero length array" syntax was copied from
>> the linux kernel headers. Changing this to a C99 flexible array
>> as you suggest, should be fine according to the constraints listed here:
> 
> Won't this break non-GCC compilers that don't support
> C99 flexible arrays?

Yes. But we require C99, and it would be
interesting to see what features we could rely
on going forward.

I had checked with solaris compilers which support
this since 2004 at least.

Though saying that, the single element hack
isn't too bad and might allow some other platform to build
without issue.

> Instead, how about this patch?  If I understand things correctly,
> it should fix the problem on NonStop, and should also work with
> pre-C99 non-GCC compilers.

feel free to push that

cheers,
Pádraig.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]