[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#6657: mkstemp on cygwin creates binary files

From: Paolo Bonzini
Subject: bug#6657: mkstemp on cygwin creates binary files
Date: Mon, 19 Jul 2010 18:31:02 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5

On 07/19/2010 03:28 PM, Eric Blake wrote:
By the way, I don't see your patch for using mkostemp on cygwin in
git://git.sv.gnu.org/sed.git; am I missing something, or is that not the
latest git repository for sed?

I wanted to make sure you liked it before pushing. :)  I'll now push it.

I also experimented with forcing "wt" or "wb" depending on the presence or absence of --binary, but I convinced myself that at least using "wt" is wrong.

For now, I won't change the behavior of building the file in /tmp. While this may make rename not atomic, it can be "corrected" anyway by setting TMPDIR=. in the environment. By comparison, "perl -i" is implemented using unlink+open which is not atomic so it's unlikely that anyone is relying on atomicity (and also wastes quota like TMPDIR=. would do).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]