Re: [PATCH] maint: enforce one small aspect of formatting style: space-before-"("

[Jim Meyering]

Eric Blake wrote:
> On 03/20/2010 05:24 AM, Jim Meyering wrote:
>> +_space_before_paren_exempt =? \\n\\$$
>> +_space_before_paren_exempt = \
>> +  (\\n\\$$|%s\(to %s|delimit-method|(date|group|character)\(s\))
>> +# Ensure that there is a space before each open parenthesis in C code.
>> +sc_space_before_open_paren:
>> +    @if $(VC_LIST_EXCEPT) | grep -l '\.[ch]$$' > /dev/null; then    \
>> +      if (cpp -fpreprocessed < /dev/null > /dev/null 2>&1); then    \
...
>> +        echo '$(ME): skipping test $@: cppi not installed' 1>&2;    \
>
> Too much copy-n-paste?  The error message should really be talking about
> 'cpp -fpreprocessed'.

Hah!  Got me.
Thanks.

>From 9f793def3cb20567666ce05d8bf570e1fdef1f76 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 20 Mar 2010 13:45:56 +0100
Subject: [PATCH] cfg.mk: fix copy-paste-o in a diagnostic

* cfg.mk (sc_space_before_open_paren): Mention cpp -fpreprocessed,
not cppi, when cpp -fpreprocessed doesn't work.
Spotted by Eric Blake.
---
 cfg.mk |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index 8a6adc2..0ce1c61 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -279,7 +279,8 @@ sc_space_before_open_paren:
              { echo '$(ME): the above files lack a space-before-open-paren' \
                  1>&2; exit 1; } || :;                                 \
          else                                                          \
-           echo '$(ME): skipping test $@: cppi not installed' 1>&2;    \
+           echo '$(ME): skipping test $@: cpp -fpreprocessed does not work' \
+             1>&2;                                                     \
          fi;                                                           \
        else :;                                                         \
        fi
--
1.7.0.2.455.g91132