bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Final point in new option of join


From: Jim Meyering
Subject: Re: Final point in new option of join
Date: Fri, 12 Feb 2010 19:14:59 +0100

Pádraig Brady wrote:
> I've added a syntax-check rule to grep the man pages
> for --options with descriptions with initial uppercase letters
> in the attached.

Thanks!

> Subject: [PATCH] doc: fix inconsistent capitalization in --help output
...

Looks fine.  One minor nit.
Rules that run a sub-make should be listed in ALL_RECURSIVE_TARGETS:

> diff --git a/cfg.mk b/cfg.mk
> index b5a21c3..dd6da25 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -171,6 +171,14 @@ ALL_RECURSIVE_TARGETS += sc_check-AUTHORS
>  sc_check-AUTHORS:
>       @$(MAKE) -C src $@
>
> +# Option descriptions should not start with a capital letter
> +# One could grep source directly as follows:
> +# grep -E " {2,6}-.*[^.]  [A-Z][a-z]" $$($(VC_LIST_EXCEPT) | grep '\.c$$')
> +# but that would miss descriptions not on the same line as the -option.

ALL_RECURSIVE_TARGETS += sc_option_desc_uppercase

> +sc_option_desc_uppercase:
> +     @$(MAKE) -C src $@
> +     @$(MAKE) -C man $@




reply via email to

[Prev in Thread] Current Thread [Next in Thread]