Re: Build error with coreutils-8.3

[Jim Meyering]

Mike Frysinger wrote:
> On Saturday 09 January 2010 03:58:02 Chris Clayton wrote:
>> I'm getting a build error with coreutils-8.3. version 8.2 builds fine
>> with the same toolset/glibc releases. The error is as follows:
>>
>> gcc version is  4.4.3 20100105 (prerelease). glibc  is 2.7.
>
> seems to be an issue with <=glibc-2.9.  at least, i have reports that
> glibc-2.11 works.

Right.
I think that without the fix below from glibc (glibc-2.9-46-g0f2ae55),
the double-inclusion code in gnulib's lib/wchar.in.h doesn't work
properly, with the result that /usr/include/wchar.h is never included.

commit 0f2ae55cf707947688bd28b55899a148fd3d7646
Author: Ulrich Drepper <address@hidden>
Date:   Mon Dec 29 23:01:38 2008 +0000

    [BZ #9694]

        * wcsmbs/wchar.h: Move undefs for local __need_* constants to the
        very end.

diff --git a/ChangeLog b/ChangeLog
index 7696705..333c502 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2008-12-29  Ulrich Drepper  <address@hidden>

+       [BZ #9694]
+       * wcsmbs/wchar.h: Move undefs for local __need_* constants to the
+       very end.
+
        * nscd/nscd_gethst_r.c (nscd_gethst_r): Don't use nscd if
        LOCALDOMAIN is defined.
        * nscd/nscd_getai.c (__nscd_getai): Likewise.
diff --git a/wcsmbs/wchar.h b/wcsmbs/wchar.h
index 0fd9e35..aaf278d 100644
--- a/wcsmbs/wchar.h
+++ b/wcsmbs/wchar.h
@@ -1,4 +1,4 @@
-/* Copyright (C) 1995-2004,2005,2006,2007 Free Software Foundation, Inc.
+/* Copyright (C) 1995-2004,2005,2006,2007, 2008 Free Software Foundation, Inc.
    This file is part of the GNU C Library.

    The GNU C Library is free software; you can redistribute it and/or
@@ -839,9 +839,9 @@ __END_DECLS

 #endif /* _WCHAR_H defined */

+#endif /* wchar.h  */
+
 /* Undefined all __need_* constants in case we are included to get those
    constants but the whole file was already read.  */
 #undef __need_mbstate_t
 #undef __need_wint_t
-
-#endif /* wchar.h  */