[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: sort link failure due to sleep

From: Jim Meyering
Subject: Re: sort link failure due to sleep
Date: Mon, 23 Nov 2009 21:30:25 +0100

Eric Blake wrote:

> In post-8.1 git, coreutils now fails to link on cygwin 1.5:
>   CCLD   sort.exe
> sort.o: In function `pipe_fork':
> /home/eblake/coreutils-tmp/src/sort.c:898: undefined reference to `_rpl_sleep'
> collect2: ld returned 1 exit status
> this was caused by the gnulib patch:
>   sleep: work around cygwin bug
> and the fact that the gnulib testsuite relies on sleep, but coreutils itself
> was not using the module.  Thus, sleep.o (and rpl_sleep) was only being
> compiled for the gnulib-tests directory.  This patch fixes it; okay to apply?
> Or should I go with an alternative patch of making sort.c use xnanosleep
> instead of sleep?  (For that matter, if we went with xnanosleep, we could make
> sort's child wait loop start with something smaller, like 0.25 seconds, 
> instead
> of a minimum granularity of 1 second.)

Hi Eric,

Your alternative patch sounds better still.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]