bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib-tests/test-update-copyright.sh perl hardcoded path


From: Jim Meyering
Subject: Re: gnulib-tests/test-update-copyright.sh perl hardcoded path
Date: Mon, 23 Nov 2009 11:30:48 +0100

Gilles Espinasse wrote:
> path is hardcoded to /us/bin/perl in
> YEAR=`/usr/bin/perl -e 'print [localtime]->[5] + 1900'`;
>
> That fail on LFS style build as perl from toolchain is in /tools/bin and
> final perl is build later

Thanks.  Fixed by the patch below.

I could have simply removed the /usr/bin/ prefix,
but using date +%s seems slightly better.  If anyone finds a
system with perl but not date, let me know and I'll switch
back to using perl.

>From 0fe2cbf6bb3dcf60a7c4004c332f9ef6ea855290 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 23 Nov 2009 11:28:00 +0100
Subject: [PATCH] test-update-copyright: don't hard-code /usr/bin/perl

* tests/test-update-copyright.sh (YEAR): Use date +%Y, rather than
perl to print the current year.  Gilles Espinasse reported that
the replaced use of perl was hard-coded as /usr/bin/perl.
---
 ChangeLog                      |    7 +++++++
 tests/test-update-copyright.sh |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 7b0217c..50712ad 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2009-11-23  Jim Meyering  <address@hidden>
+
+       test-update-copyright: don't hard-code /usr/bin/perl
+       * tests/test-update-copyright.sh (YEAR): Use date +%Y, rather than
+       perl to print the current year.  Gilles Espinasse reported that
+       the replaced use of perl was hard-coded as /usr/bin/perl.
+
 2009-11-23  Bruno Haible  <address@hidden>

        duplocale: Add support for glibc 2.3.x.
diff --git a/tests/test-update-copyright.sh b/tests/test-update-copyright.sh
index 859c75d..d555239 100755
--- a/tests/test-update-copyright.sh
+++ b/tests/test-update-copyright.sh
@@ -223,7 +223,7 @@ rm $TMP*
 ## -------------- ##

 TMP=$TMP_BASE-current-year
-YEAR=`/usr/bin/perl -e 'print [localtime]->[5] + 1900'`;
+YEAR=`date +%Y`
 cat > $TMP <<EOF
 '\" Copyright (C) 2006
 '\" Free Software Foundation,
--
1.6.6.rc0.203.g7074f




reply via email to

[Prev in Thread] Current Thread [Next in Thread]