[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tail: fix a race condition
From: |
Jim Meyering |
Subject: |
Re: [PATCH] tail: fix a race condition |
Date: |
Thu, 22 Oct 2009 11:51:57 +0200 |
Jim Meyering wrote:
> Giuseppe Scrivano wrote:
> ...
>> Subject: [PATCH] tests: add a new test that checks for a possible `tail'
>> race.
>>
>> If new data is available between the initial read and tail registers the
>> inotify
>> watch descriptors, ensure that it is read before a new event happens on the
>> file.
>>
>> * tests/Makefile.am (TESTS): Add tail-2/inotify-race.
>> * tests/tail-2/inotify-race: New file.
>
> Thanks.
> I'm merging the following, too:
>
> The first hunk is so the test isn't mistakenly skipped
> when in VERBOSE=yes mode.
>
> There's no need to specify the full name of "tail".
>
> I added the comment so I'll still understand what this test
> was doing if I reread it in a year or so ;-)
I've pushed your fix and the added test:
http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=029b6b14c5c4
http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=cd0f3036f606
- [PATCH] tail: fix a race condition, Giuseppe Scrivano, 2009/10/12
- Re: [PATCH] tail: fix a race condition, Jim Meyering, 2009/10/13
- Re: [PATCH] tail: fix a race condition, Giuseppe Scrivano, 2009/10/13
- Re: [PATCH] tail: fix a race condition, Giuseppe Scrivano, 2009/10/20
- Re: [PATCH] tail: fix a race condition, Pádraig Brady, 2009/10/20
- Re: [PATCH] tail: fix a race condition, Jim Meyering, 2009/10/20
- Re: [PATCH] tail: fix a race condition, Giuseppe Scrivano, 2009/10/20
- Re: [PATCH] tail: fix a race condition, Jim Meyering, 2009/10/20
- Re: [PATCH] tail: fix a race condition, Giuseppe Scrivano, 2009/10/20
- Re: [PATCH] tail: fix a race condition, Jim Meyering, 2009/10/22
- Re: [PATCH] tail: fix a race condition,
Jim Meyering <=