bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: uptime: fix a theoretical compile error


From: Jim Meyering
Subject: Re: [PATCH] maint: uptime: fix a theoretical compile error
Date: Tue, 22 Sep 2009 12:32:58 +0200

Pádraig Brady wrote:
>>From af8f446d3ff9962399a93a20f33e372e57e0daa2 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
> Date: Tue, 22 Sep 2009 08:01:44 +0100
> Subject: [PATCH] maint: uptime: fix a theoretical compile error
>
> * src/uptime.c (print_uptime): Reference possibly unused arguments
> ---
>  src/uptime.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/src/uptime.c b/src/uptime.c
> index 0449c6d..cb3dcf0 100644
> --- a/src/uptime.c
> +++ b/src/uptime.c
> @@ -111,7 +111,11 @@ print_uptime (size_t n, const STRUCT_UTMP *this)
>          boot_time = UT_TIME_MEMBER (this);
>        ++this;
>      }
> +#else
> +  (void) n;
> +  (void) this;
>  #endif

Theoretical, indeed ;-)

When a ChangeLog entry affects #ifdef'd code,
adding the affected condition (at least when it's
not too long) in brackets makes the summary more useful:

And this would avoid a warning (albeit sometimes mapped to an error via 
-Werror):

  maint: uptime: fix a theoretical compiler warning

  * src/uptime.c (print_uptime) [!HAVE_UTMPX_H && !HAVE_UTMP_H]:
  Reference possibly unused arguments.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]