Re: rmdir errno cleanup

[Jim Meyering]

Eric Blake wrote:
> OK to commit this?  POSIX allows rmdir("non-empty-dir") to fail with either
> ENOTEMPTY (Linux) or EEXIST (Solaris).  But the gnulib module rmdir-errno
> blindly assumes ENOTEMPTY during cross-compilation; it seems like we could be
> safer by listing both cases explicitly, rather than risking a failed cross-
> compilation to Solaris.
>
> Meanwhile, I will be un-obsoleting the gnulib module rmdir, to work around a
> cygwin 1.5.x bug where rmdir("empty/.") correctly fails, but rmdir("empty/./")
> accidently removes "empty".
>
>
> From: Eric Blake <address@hidden>
> Date: Wed, 16 Sep 2009 08:27:07 -0600
> Subject: [PATCH] rm, rmdir: improve cross-compilation support
>
> * bootstrap.conf (gnulib_modules): Drop rmdir-errno.
> * src/rmdir.c (errno_rmdir_non_empty): Check both cases allowed by
> POSIX, rather than relying on configure-time check that might
> fail during cross-compilation.  Reverts commit 9b6eb98d41.

This is a good change, even if it's only theoretical.
Please push it.