Re: [PATCH] cp, mv: do preserve extended attributes even for read-only source files

[Ondřej Vašík]

Pádraig Brady wrote:
> Yes I agree that the change is required.
> I've tweaked it so that the geteuid() syscall is only called
> if readonly files. Also I removed the error message on chmod failure
> as the user will still get an error message _if_ the copy_xattr fails.
> Also I ran it through indent and did s/write access rights/write access/.
> I'll push it soon if there are no objections.

Thanks for word tweaks and other patch-amending. I spotted one error -
initial value of access_changed was not changed to false when you
changed the name and logic from access_unchanged (fixed by attached
patch).

Greetings,
         Ondřej

initial_value.patch
Description: Text Data

signature.asc
Description: Toto je digitálně podepsaná část zprávy