Bug#545009: coreutils: FTBFS on GNU/kFreeBSD (testsuite failure of tests/tail-2/wait)

[Petr Salinger]

Package: coreutils
Version: 7.5-1
Severity: important
Tags: patch
User: address@hidden
Usertags: kfreebsd
X-Debbugs-CC: address@hidden

Hi,

the current version fails to build on GNU/kFreeBSD
due to failure in tests/tail-2/wait.

The problem is that GNU/kFreeBSD is not inotify capable
and the current default of --max-unchanged-stats is 5.
It together with
 - second time stamp precision of underlying filesystems
 - -s.1
 - sleep .5

might easily lead into that in

                  if ((max_n_unchanged_stats_between_opens
                       <= f[i].n_unchanged_stats++)
                      && follow_mode == Follow_name)
                    {
                      recheck (&f[i], f[i].blocking);
                      f[i].n_unchanged_stats = 0;
                    }

the recheck is not done before "echo NO" happens in the test:

touch k
mv k l
sleep .5
echo NO >> l

The corresponding code above is not used for inotify capable systems.
Please change the test as shown bellow.

Petr


--- tests/tail-2/wait
+++ tests/tail-2/wait
@@ -118,7 +118,7 @@

 test -s tail.err && fail=1

-tail -s.1 -F k > tail.out &
+tail -s.1 --max-unchanged-stats=2 -F k > tail.out &
 pid=$!
 sleep .5
 ls -al