Re: test results

[Jim Meyering]

Russell Whitaker wrote:
> Source: slackware-current/source
> Modified SlackBuild to build as i686
> Compiler: gcc-4.4.1
> Test suite ran as su
>
> 3 fails, individual logs attached
>
> Let me know if this was helpful
> Thanks,
>      Russ
>
> make  check-TESTS
> make[1]: Entering directory `/tmp/coreutils-7.4/tests'
> make[2]: Entering directory `/tmp/coreutils-7.4/tests'
> FAIL: misc/stty
> =============================================
>    GNU coreutils 7.4: tests/test-suite.log

Thanks for testing and for reporting the results.
FYI, coreutils-7.5 was released just a couple days ago.
(though it has improvements, you'll probably see these
same three failures)

> FAIL: misc/stty (exit: 1)
> FAIL: misc/stty-row-col

I haven't seen those stty test failures before,
so perhaps it something specific to your system.
On the other hand, it is not recommended to run *all*
tests as root (just in case there's a bug in a test
that can be abused).  Instead, we suggest that you run only
those tests that require root privileges in order to operate.
See details in the README file.

Can you reproduce that failure while running the test as non-root?

> FAIL: cp/cp-mv-enotsup-xattr
...
> + NON_ROOT_USERNAME=nobody
> ++ pwd
> + cwd=/tmp/coreutils-7.4/tests/cu-cp-mv-enotsup-xattr.xBikufnX9I
> + dd if=/dev/zero of=blob bs=8192 count=200
> + mkdir mnt
> + mkfs -t ext2 -F blob
> mke2fs 1.41.3 (12-Oct-2008)
> Filesystem label=
> OS type: Linux
> Block size=1024 (log=0)
> Fragment size=1024 (log=0)
> 200 inodes, 1600 blocks
> 80 blocks (5.00%) reserved for the super user
> First data block=1
> Maximum filesystem blocks=1835008
> 1 block group
> 8192 blocks per group, 8192 fragments per group
> 200 inodes per group
>
> Writing inode tables: 0/1done
> Writing superblocks and filesystem accounting information: done
>
> This filesystem will be automatically checked every 27 mounts or
> 180 days, whichever comes first.  Use tune2fs -c or -i to override.
> + mount -oloop,nouser_xattr blob mnt
> mount: unknown filesystem type 'ext2'
> + framework_failure
> + error_ 'failure in testing framework'
> + echo './cp/cp-mv-enotsup-xattr: failure in testing framework'
> ./cp/cp-mv-enotsup-xattr: failure in testing framework

Technically, this test should be skipped upon failure to mount
the just-created file system, so that the failure doesn't make
people worry that there may be a problem in the tool under test.

I've just fixed it in the repository:

>From 831acb987e970ca86b72eb594965ff59bfedfd30 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 23 Aug 2009 22:02:12 +0200
Subject: [PATCH] tests: skip (don't fail) a cp test, upon mount-related failure

* tests/cp/cp-mv-enotsup-xattr: Upon a set-up failiure, rather than
failing the test with a "framework failure" diagnostic, just skip it.
Russell Whitaker reported that this test failed on slackware.
---
 tests/cp/cp-mv-enotsup-xattr |   17 ++++++++++-------
 1 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/tests/cp/cp-mv-enotsup-xattr b/tests/cp/cp-mv-enotsup-xattr
index 23ec4f3..8f3020b 100755
--- a/tests/cp/cp-mv-enotsup-xattr
+++ b/tests/cp/cp-mv-enotsup-xattr
@@ -30,16 +30,20 @@ require_root_
 cwd=`pwd`
 cleanup_() { cd /; umount "$cwd/mnt"; }

+skip=0
 # Create a file system without user xattr support, then mount it.
 dd if=/dev/zero of=blob bs=8192 count=200 > /dev/null 2>&1 \
-                                             || framework_failure
-mkdir mnt                                    || framework_failure
+                                             || skip=1
+mkdir mnt                                    || skip=1
 mkfs -t ext2 -F blob ||
   skip_test_ "failed to create ext2 file system"

-mount -oloop,nouser_xattr blob mnt           || framework_failure
-echo test > mnt/f                            || framework_failure
-test -s mnt/f                                || framework_failure
+mount -oloop,nouser_xattr blob mnt           || skip=1
+echo test > mnt/f                            || skip=1
+test -s mnt/f                                || skip=1
+
+test $skip = 1 \
+    && skip_test_ "insufficient mount/ext2 support"

 # testing xattr name-value pair
 xattr_name="user.foo"
@@ -55,8 +59,7 @@ getfattr -d a >out_a || skip_test_ "failed to get xattr of 
file"
 grep -F "$xattr_pair" out_a >/dev/null \
   || skip_test_ "failed to set xattr of file"

-fail=0                                       || framework_failure
-
+fail=0

 # This should pass without diagnostics
 cp -a a mnt/ 2>err  || fail=1
--
1.6.4.378.g88f2f