bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

AW: AW: AW: AW: AW: AW: AW: AW: new snapshot available: coreutils-7.4.12


From: Voelker, Bernhard
Subject: AW: AW: AW: AW: AW: AW: AW: AW: new snapshot available: coreutils-7.4.125-eca6
Date: Thu, 20 Aug 2009 10:15:36 +0200

Jim Meyering wrote:
> I suspect this patch works around your compiler's
> inadequate "bool" support:
> 
> diff --git a/src/install.c b/src/install.c
> index 73b3981..19efb1d 100644
> --- a/src/install.c
> +++ b/src/install.c
> @@ -189,7 +189,7 @@ static bool
>  extra_mode (mode_t input)
>  {
>    const mode_t mask = ~S_IRWXUGO & ~S_IFMT;
> -  return input & mask;
> +  return !! (input & mask);
>  }
> 
>  /* Return true if copy of file SRC_NAME to file DEST_NAME is
necessary. */

perfect (output still incl. my fprintf):

  $ ./ginstall -Cv -m$mode3 a b
  extra_mode(1517) -> 1024
  ./ginstall: the --compare (-C) option is ignored when you specify a
mode with non-permission bits
  extra_mode(1517) -> 1024
  removed `b'
  `a' -> `b'

and `make TESTS='install/install-C' check`:

  PASS: install/install-C
  =============
  1 test passed
  =============

Thank you.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]