[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ls: Use pretty UTF-8 arrow when showing where symlinks point
From: |
Lennart Poettering |
Subject: |
Re: [PATCH] ls: Use pretty UTF-8 arrow when showing where symlinks point to |
Date: |
Tue, 11 Aug 2009 23:48:31 +0200 |
User-agent: |
Leviathan/19.8.0 [zh] (Cray 3; I; Solaris 4.711; Console) |
On Tue, 11.08.09 22:27, Pádraig Brady (address@hidden) wrote:
> this is equivalent I think:
>
> static const char *arrow = " -> ";
> #ifdef HAVE_NL_LANGINFO
> if (fancy_chars && STREQ (nl_langinfo (CODESET), "UTF-8"))
> arrow = " \xe2\x86\x92 ";
> #endif
> DIRED_FPUTS_LITERAL (arrow, stdout);
You evaluate the whole expression on every iteration. The whole point
of making this variable static is to make sure this isn't necessary.
Lennart
--
Lennart Poettering Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/ GnuPG 0x1A015CC4