Re: [PATCH] chroot specify user/group feature

[Jim Meyering]

Giuseppe Scrivano wrote:
...
>>   - do not add short-named options.  People who want to
>>       abbreviate can use --u or --g.
>>   - exit right away upon encountering an invalid option.
>>       Make the option-processing loop look like most others, i.e.,
>>       with a switch and anonymous enum values in place of your
>>       current 'u' and 'g'.
>
> What do you think if I change 'g' to 'G'?  I looked under FreeBSD and
> they use -u, -g and -G, maybe it worths to keep the same name.
> Under OpenBSD it is not possible to specify additional groups, so only
> -u and -g are available.

Oh, if you're adding options that mirror precisely what e.g.,
FreeBSD does, then it seems like it'd be ok to add short-named ones.

>>   - add a NEWS entry
>>   - add documentation in coreutils.texi
>>
>> And for extra credit,
>>
>>   - add a test or two to exercise the new functionality.
>>       It'll have to be a root-only test, of course.
>
> Sure, I thought about add all these things after you approved it.

Great!