Re: [PATCH] sort: Add --threads option, which parallelizes internal sort.

[Jim Meyering]

>> Paul Eggert writes:
>>>
>>> This patch is by Glen Lenker, Matt Pham, Benjamin Nuernberger, Sky
>>> Lin, TaeSung Roh, and Paul Eggert.  It adds support for parallelism
>>> within an internal sort.  On our simple tests on a 2-core desktop x86,
>>> overall performance improved by roughly a factor of 1.6.

In my local branch with this change, I'm about to merge this
into the primary change set.

>From 2f4edf2e997e3354ca8179b181b1f95037834473 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 3 Apr 2009 07:39:31 +0200
Subject: [PATCH] remove obsolete comment

---
 src/sort.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/sort.c b/src/sort.c
index b4f0dfb..b6e0ee8 100644
--- a/src/sort.c
+++ b/src/sort.c
@@ -1,5 +1,5 @@
 /* sort - sort lines of text (with all kinds of options).
-   Copyright (C) 1988, 1991-2008 Free Software Foundation, Inc.
+   Copyright (C) 1988, 1991-2009 Free Software Foundation, Inc.

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -2538,10 +2538,7 @@ sortlines_thread (void *data)
    singlethreaded, use the optimization suggested by Knuth exercise
    5.2.4-10, which requires room for only 1.5*N lines, rather than the
    usual 2*N lines.  Knuth writes that this memory optimization was
-   originally published by D. A. Bell, Comp J. 1 (1958), 75.
-
-   This function is inline so that its tests for multthreadedness and
-   inplacedness can be optimized away in common cases.  */
+   originally published by D. A. Bell, Comp J. 1 (1958), 75.  */

 static void
 sortlines (struct line *restrict lines, size_t nlines,
--
1.6.2.rc1.285.gc5f54