bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Degraded performance in cat + patch


From: Jim Meyering
Subject: Re: Degraded performance in cat + patch
Date: Wed, 11 Mar 2009 13:59:39 +0100

Pádraig Brady wrote:
> +enum { IO_BUFSIZE = 32*1024; };
> +static inline size_t
> +io_blksize (struct stat sb)
> +{
> +  return MAX (IO_BUFSIZE, ST_BLKSIZE (sb));
> +}

You can also move the definition of IO_BUFSIZE into the function,
and avoid imposing that name on all who include system.h.

> version I'll push soonish

Go for it.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]