bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: changing NEWS' copyright date must not invalidate che


From: Jim Meyering
Subject: Re: [PATCH] maint: changing NEWS' copyright date must not invalidate checksum
Date: Thu, 19 Feb 2009 07:58:40 +0100

> Jim Meyering <jim <at> meyering.net> writes:
> Sorry for not adjusting the hash myself.
> Filtering out the copyright year is a good change.
>
>>  NEWS_hash = \
>>    $$(sed -n '/^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)/,$$p' \
>> -     $(srcdir)/NEWS | md5sum -)
>> +     $(srcdir)/NEWS | grep -v '^Copyright .*Free Software' | md5sum -)
>
> Is it worth saving a process here, by folding the grep -v into the sed?
>
> NEWS_hash = \
>   $$(sed -n 's/^Copyright .*Free Software.*//; \
>      /^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)/,$$p' \
>      $(srcdir)/NEWS | md5sum -)

Not for that reason, but now that I see your all-sed solution,
how about *not* excluding the Copyright line, but merely year numbers?
Then, an improbable accident that simply removed the line would not
get by the check.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]