[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] more portable bootstrap procedure
From: |
Jim Meyering |
Subject: |
Re: [PATCH] more portable bootstrap procedure |
Date: |
Sat, 13 Dec 2008 15:29:44 +0100 |
Ralf Wildenhues <address@hidden> wrote:
> * Jim Meyering wrote on Sat, Dec 13, 2008 at 01:52:46PM CET:
>> Ralf Wildenhues <address@hidden> wrote:
>> > * Jim Meyering wrote on Sat, Dec 13, 2008 at 01:09:10PM CET:
>> >> Ralf Wildenhues <address@hidden> wrote:
>> >> >
>> >> > There is one question I have on this: coreutils requires 'tar', my patch
>> >> > will allow $TAR as GNU tar. However, Automake's macros will honor
>> >> > $AMTAR only, not $TAR. Is this where tar is used, or are there other
>> >> > instances I am not aware of? If yes, should I fix check_versions to
>> >> > check $AMTAR instead of $TAR?
>> >
>> >> Whichever you prefer is fine with me. I use neither.
>> >
>> > Well, why is tar then listed as a build prerequisite in bootstrap.conf?
>> > Have you had a bad experience with non-GNU tar in 'make dist'?
>>
>> Personally, I'd like tar to honor the TAR_OPTIONS envvar,
>> as set in GNUmakefile. But that's useful only when creating
>> a distribution tarball, and even then, it's not critical.
>
> Hmm, ok, I understand the point. Well, up to you, that s/TAR/AMTAR/
> change would be fine with me.
Since it's your change, you do need to sign off on the incremental ;-)
Is this what you suggest?
diff --git a/bootstrap b/bootstrap
index 9c98851..af4b088 100755
--- a/bootstrap
+++ b/bootstrap
@@ -52,7 +52,7 @@ Options:
If the file $0.conf exists in the same directory as this script, its
contents are read as shell variables to configure the bootstrap.
-For build requisites, environment variables like \$AUTOCONF or \$TAR
+For build requisites, environment variables like \$AUTOCONF or \$AMTAR
are honored.
Running without arguments will suffice in most cases.
@@ -284,6 +284,7 @@ check_versions() {
while read app req_ver; do
# Honor $APP variables ($TAR, $AUTOCONF, etc.)
appvar=`echo $app | tr '[a-z]' '[A-Z]'`
+ test "$appvar" = TAR && appvar=AMTAR
eval "app=\${$appvar-$app}"
inst_ver=$(get_version $app)
if [ ! "$inst_ver" ]; then
Re: [PATCH] more portable bootstrap procedure, Pádraig Brady, 2008/12/13