bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

group-list warning


From: Eric Blake
Subject: group-list warning
Date: Fri, 24 Oct 2008 17:44:42 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

During the window of buggy autoconf, I saw this evidence of a latent bug for 
platforms that lack getgroups:

group-list.c: In function `print_group_list':
group-list.c:89: warning: control reaches end of non-void function

OK to commit?

From: Eric Blake <address@hidden>
Date: Fri, 24 Oct 2008 11:42:29 -0600
Subject: [PATCH] group-list: avoid compiler warning

* src/group-list.c (print_group_list) [!HAVE_GETGROUPS]: Always return value.
---
 src/group-list.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/group-list.c b/src/group-list.c
index 96438d9..3547ed6 100644
--- a/src/group-list.c
+++ b/src/group-list.c
@@ -83,9 +83,9 @@ print_group_list (const char *username,
             ok = false;
         }
     free (groups);
-    return ok;
   }
 #endif /* HAVE_GETGROUPS */
+  return ok;
 }
 
 
-- 
1.6.0.2







reply via email to

[Prev in Thread] Current Thread [Next in Thread]