Re: [PATCH] Add option processing tests for 'expr'

[Jim Meyering]

Pádraig Brady <address@hidden> wrote:
> The attached tests pass with both your and Paul's patches.
>
> I didn't add --bignum into the tests as I assumed
> those options are being removed imminently.

Thanks!
looks perfect

Only nit: I changed the one-line summary to start with "tests: "

I've just pushed 3 change sets:
  - mine with the minimal fix
  - Paul's adjusted to apply on top of mine (I merged the reverse
      of mine into his)
  - your test additions


>>From cc29aaeaa6f1d22199abc6eb2e94a62fab46a8f5 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
> Date: Wed, 15 Oct 2008 15:01:43 +0100
> Subject: [PATCH] Add option processing tests for 'expr'
>
> * tests/misc/expr: Add tests for various combinations
> of options where the first part of the expression
> could be confused with an option.
> ---
>  tests/misc/expr |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/tests/misc/expr b/tests/misc/expr
> index 4d23662..62e8ccb 100755
> --- a/tests/misc/expr
> +++ b/tests/misc/expr
> @@ -39,6 +39,15 @@ my @Tests =
>       ['f', '3 + -2', {OUT => '1'}],
>       ['g', '-2 + -2', {OUT => '-4'}],
>
> +     # Verify option processing.
> +     # Added when option processing broke in the 7.0 beta release
> +     ['opt1', '-- -11 + 12', {OUT => '1'}],
> +     ['opt2', '-11 + 12', {OUT => '1'}],
> +     ['opt3', '-- -1 + 2', {OUT => '1'}],
> +     ['opt4', '-1 + 2', {OUT => '1'}],
> +     # This evoked a syntax error diagnostic before 2.0.12.
> +     ['opt5', '-- 2 + 2', {OUT => '4'}],
> +
>       ['paren1', '\( 100 % 6 \)', {OUT => '4'}],
>       ['paren2', '\( 100 % 6 \) - 8', {OUT => '-4'}],
>       ['paren3', '9 / \( 100 % 6 \) - 8', {OUT => '-6'}],
> @@ -59,8 +68,6 @@ my @Tests =
>       # In 5.1.3 and earlier, this would output the empty string.
>       ['orempty', '"" \| ""', {OUT => '0'}, {EXIT => 1}],
>
> -     # This evoked a syntax error diagnostic before 2.0.12.
> -     ['minus2', '-- 2 + 2', {OUT => '4'}],
>
>       # This erroneously succeeded and output `3' before 2.0.12.
>       ['fail-a', '3 + -', {ERR => "$prog: non-numeric argument\n"},