[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: new snapshot available: coreutils-6.12.208-2441
From: |
Eric Blake |
Subject: |
Re: new snapshot available: coreutils-6.12.208-2441 |
Date: |
Sat, 27 Sep 2008 18:16:28 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080914 Thunderbird/2.0.0.17 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Jim Meyering on 9/27/2008 3:45 AM:
> Here's a snapshot of the latest sources from coreutils
> and the parts of gnulib that it uses. Please beat it up ;-)
OK to apply this minor cleanup, to avoid a warning on deficient platforms?
ccache gcc -std=gnu99 -I. -I../lib -I../lib -I/usr/local/include
- -gdwarf-2 -Wall -Werror -MT remove.o -MD -MP -MF .deps/remove.Tpo -c -o
remove.o remove.c
ranlib libver.a
remove.c:1263: warning: 'compare_ino' defined but not used
remove.c:1274: warning: 'dirent_count' defined but not used
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkjezNwACgkQ84KuGfSFAYD21gCgpCk0uhrYiUV9p74WlEUP1bXP
MFoAnArjbQXplldoWi/GcOO4Noh1qfQd
=Tw7V
-----END PGP SIGNATURE-----
From 58aaf71f0756eada2180553bcbf3686a0c3249bd Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Sat, 27 Sep 2008 18:14:07 -0600
Subject: [PATCH] remove.c: avoid compiler warning
* src/remove.c (compare_ino, dirent_count)
[!HAVE_STRUCT_DIRENT_D_TYPE]: Mask declaration when unused.
Signed-off-by: Eric Blake <address@hidden>
---
src/remove.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/remove.c b/src/remove.c
index 26f096e..ea52843 100644
--- a/src/remove.c
+++ b/src/remove.c
@@ -1257,6 +1257,7 @@ struct readdir_data
char name[FLEXIBLE_ARRAY_MEMBER];
};
+#if HAVE_STRUCT_DIRENT_D_TYPE
/* A comparison function to sort on increasing inode number. */
static int
compare_ino (void const *av, void const *bv)
@@ -1274,6 +1275,7 @@ dirent_count (struct stat const *st)
{
return st->st_size / 16;
}
+#endif /* HAVE_STRUCT_DIRENT_D_TYPE */
/* When a directory contains very many entries, operating on N entries in
readdir order can be very seek-intensive (be it to unlink or even to
--
1.6.0.2
Re: new snapshot available: coreutils-6.12.208-2441, Elbert Pol, 2008/09/28