[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remov
|
From: |
Ralf Wildenhues |
|
Subject: |
Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c |
|
Date: |
Fri, 26 Sep 2008 08:14:25 +0000 (UTC) |
|
User-agent: |
Loom/3.14 (http://gmane.org/) |
Hello Jim, a tiny nit again:
Jim Meyering <jim <at> meyering.net> writes:
> +/* A comparison function to sort on increasing inode number. */
> +static int
> +compare_ino (void const *av, void const *bv)
> +{
> + struct readdir_data const *const *a = av;
> + struct readdir_data const *const *b = bv;
> + return a[0]->ino - b[0]->ino;
> +}
Susceptible to integer overflow, like the gnulib code.
Cheers,
Ralf
- rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c, Jim Meyering, 2008/09/25
- Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c, Eric Blake, 2008/09/25
- Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c,
Ralf Wildenhues <=
- Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c, Andreas Schwab, 2008/09/26
- Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c, Jim Meyering, 2008/09/26