Re: sort --version-sort

[Jim Meyering]

Eric Blake <address@hidden> wrote:
> Jim Meyering <jim <at> meyering.net> writes:
>> commit 4c9fae4e97d95a9f89d1399a8aeb03051f0fec96
>> Author: Bruce Korb <bkorb <at> gnu.org>
>> Date:   Thu Aug 14 06:24:59 2008 -0700
>>
>>     sort: new option, --sort=version, for version number ordering
>
> I now get this on cygwin:
>
> sort.c: In function `compare_version':
> sort.c:1839: warning: implicit declaration of function `strverscmp'
>
> Would you rather I submit a simple patch to coreutils that adds
> #include "strverscmp.h" to sort.c, or a more complete patch to gnulib that
> guarantees a declaration of strverscmp in the gnulib replacement <string.h> to
> match Linux?

What service ;-)

I think we'll have to include "strverscmp.h",
since portable applications should be expecting a
strverscmp declaration in string.h.

Thanks!