bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix build-aux/check.mk for non-GNU make.


From: Jim Meyering
Subject: Re: [PATCH] Fix build-aux/check.mk for non-GNU make.
Date: Sat, 02 Aug 2008 13:52:49 +0200

Ralf Wildenhues <address@hidden> wrote:
> * build-aux/check.mk ($(TEST_LOGS)) [!GNU_MAKE]: Check for
> a $(TESTS) test in the build dir, before one in srcdir.
> ---
>
> Hmpf.  First, this updated patch fixes the alignment of backslash
> newline.
>
> Second, I should note that this whole shenanigan only works well because
> automake inserts an '$(MAKE) ... $(check_PROGRAMS)' earlier, so that it
> is clear that the TESTS entry exists if it has been built, iff it has
> been listed in check_PROGRAMS.
>
> I believe this to be no problem for well-written Makefile.am files.

Thanks for the stress-testing, and especially for taking the time to
track down and fix such problems.

I've applied your patch.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]