|
From: | Philip Rowlands |
Subject: | Re: [PATCH] Again, do not change the mode of all directories below $HOME. |
Date: | Tue, 22 Jul 2008 09:19:36 +0100 (BST) |
On Tue, 22 Jul 2008, Ralf Wildenhues wrote:
* tests/CuTmpdir.pm (chmod_tree): Do not run chmod on undefined argument, can happen when the build path contains spaces.
That sounds wrong - there's no magic to unusual characters in filenames other than avoiding passing them unquoted through an IFS-splitting shell.
sub chmod_tree { - if (chdir $dir) + if (defined $dir && chdir $dir) {
Surely skipping the test is going to give a misleading impression to the tester? Tracing back up, why is $dir not defined?
Cheers, Phil
[Prev in Thread] | Current Thread | [Next in Thread] |