bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Clarify field delimiter description in uniq --help output


From: Jim Meyering
Subject: Re: [PATCH] Clarify field delimiter description in uniq --help output
Date: Mon, 19 May 2008 13:32:08 +0200

Pádraig Brady <address@hidden> wrote:
> Jim Meyering wrote:
>>> Hi Pádraig,
>>>
>>> Thanks!
>>> Your summary is right, but the --help change is slightly
>>> inaccurate, since "blank" can mean more than just SPC or TAB.
>
> Yes you're right for non C locales.
>
> In my en_IE.utf8 locale isblank() is the larger set of:
>
> 0009 TAB
> 0020 SPACE
> 1680 OGHAM SPACE MARK
> 180E MONGOLIAN VOWEL SEPARATOR
...

> It could also be argued that my "spaces or tabs" was more descriptive,
> and could also imply the "spaces" above?
> Personally I had to `man isblank` to see what was considered blank,
> and the linux man page only mentions the space and tab chars anyway.

I agree that more detail would be better.
What do you think of this additional change?

diff --git a/src/uniq.c b/src/uniq.c
index 4f0d5c0..ce883d7 100644
--- a/src/uniq.c
+++ b/src/uniq.c
@@ -165,8 +165,8 @@ Mandatory arguments to long options are mandatory for short 
options too.\n\
      fputs (VERSION_OPTION_DESCRIPTION, stdout);
      fputs (_("\
 \n\
-A field is a run of blanks, then non-blank characters.\n\
-Fields are skipped before chars.\n\
+A field is a run of blanks (usually spaces and/or TABs), then non-blank\n\
+characters.  Fields are skipped before chars.\n\
 "), stdout);
      fputs (_("\
 \n\




reply via email to

[Prev in Thread] Current Thread [Next in Thread]