Re: Bug report: tac crash

[Jim Meyering]

Jim Meyering <address@hidden> wrote:
> Jim Meyering <address@hidden> wrote:
>> Daniel Dunbar <address@hidden> wrote:
>>> The following crashes tac on my machine (6.10 and 6.11):
>>> --
>>> $ echo > x; tac -r x x
>>> Segmentation fault
>>> --
...
> Here's what I've just pushed:
>
>>From d701f6abb73e36721de5df083df4769786a14528 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Mon, 5 May 2008 00:07:08 +0200
> Subject: [PATCH] tac: avoid segfault for e.g., "echo > x; tac -r x x"
>
> * src/tac.c (tac_seekable): Move local "regs" declaration out
> to file scope, so its values aren't clobbered between calls.
> Discovered by Cristian Cadar, Daniel Dunbar and Dawson Engler,
> reported in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/13501
> * NEWS: Mention the bug fix.
> * tests/Makefile.am (TESTS): Add misc/tac.
> * tests/misc/tac: New file.  Test for the above.
...
> diff --git a/tests/misc/tac b/tests/misc/tac
> new file mode 100644

Whoops.  Wrong "mode".
I've just pushed the change to make it executable.