[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix test failure where rm would appear to succeed incorrectly.
From: |
Jim Meyering |
Subject: |
Re: Fix test failure where rm would appear to succeed incorrectly. |
Date: |
Mon, 25 Feb 2008 23:15:53 +0100 |
address@hidden (Bob Proulx) wrote:
> I have been seeing the rm fail-eperm test sporadically fail. It turns
> out that there is a race. The test is opportunistically looking for
> files that it can't remove so as to provide a test for that part of
> rm's functionality. But between the time it finds a candidate file
> and the time it tries to test rm on the file that file may have
> already been removed external to the test script. The code didn't
> expect that and therefore threw an error message. This suggested
> patch fixes the problem by detecting that case and ignoring it.
>
> Please fetch this patch.
>
> git fetch --no-tags git://git.proulx.com/idutils
> rm-fail-eperm-fix:rm-fail-eperm-fix
>
> 2008-02-25 Bob Proulx <address@hidden>
>
> Fix test failure where rm would appear to succeed incorrectly.
> * tests/rm/fail-eperm: Ignore files that were opportunistically chosen
> to test permission failures but disappear before we can finish the test.
Thanks for tracking that down and fixing it.
I applied your patch. (though, fyi, the fetch failed)