bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use the gettime module in ls.c.


From: Jim Meyering
Subject: Re: [PATCH] Use the gettime module in ls.c.
Date: Sat, 16 Feb 2008 19:35:31 +0100

James Youngman <address@hidden> wrote:
> 2008-02-16  James Youngman  <address@hidden>
>
>       Implement TODO list item to make ls.c use the gettime module.
>       * TODO (ls): Now that we use gettime, remove the TODO entry.
>       * src/ls.c: Use timespec.h and the gettime module.
>       (current_time): Change type from time_t to struct timespec.
>       (current_time_ns): Removed.
>       (get_current_time): Removed.
>       (print_long_format): Remove when and when_ns, since we have
>       when_timespec anyway.  Change type of variable six_months_ago from
>       time_t to struct timespec.
...
> diff --git a/src/ls.c b/src/ls.c
> index 46713f2..5f466ca 100644
> --- a/src/ls.c
> +++ b/src/ls.c
> @@ -101,6 +101,7 @@
>  #include "quotearg.h"
>  #include "same.h"
>  #include "stat-time.h"
> +#include "timespec.h"

Thank you!
I've applied that modulo two nits:
- don't include timespec.h
- don't add trailing blanks

Both of which are checked by running "make distcheck".




reply via email to

[Prev in Thread] Current Thread [Next in Thread]