[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: sort --compare-version

From: Jim Meyering
Subject: Re: sort --compare-version
Date: Sun, 10 Feb 2008 16:19:49 +0100

Andreas Schwab <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>> Andreas Schwab <address@hidden> wrote:
>>> Bruce Korb <address@hidden> writes:
>>>> Yep.  That's the reason for the "compare-" prefix.  I didn't like
>>>> ``--compare-version-sort'' for some sort of reason, too.  Ultimately,
>>>> someone pick another name if "compare-version" is aesthetically bad.
>>> How about making it --sort=KEYWORD, with KEYWORD in
>>> {general-numeric,month,numeric,random,version}?
>> I like it.
> Here's a patch to add --sort.
> Andreas.
> 2008-02-09  Andreas Schwab  <address@hidden>
>       Add --sort option.
>       * src/sort.c (SORT_OPTION): New enum.
>       (sort_args, sort_types): Define.
>       (usage, long_options, main): New option --sort.

Thanks for writing that.
I appreciate your including a ChangeLog entry.

Do you feel like adding a few tests (tests/sort/Test.pm) to exercise
the new feature, and adding to coreutils.texi and NEWS?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]