[PATCH] Use strdup in dd to avoid changing argv elements

[Adam Goode]

Hi,

Right now, dd uses strchr to do some parsing of argv. This messes up how
dd appears in ps.

Here is a very simple solution to this problem. Yes, it does not free
memory. But does it matter? dd is just a standalone application.

(Pointed out by Benjamin Gilbert.)


Adam



---
 src/dd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/dd.c b/src/dd.c
index cc1ba0c..b8ab8a9 100644
--- a/src/dd.c
+++ b/src/dd.c
@@ -877,7 +877,7 @@ scanargs (int argc, char **argv)
     {
       char *name, *val;

-      name = argv[i];
+      name = strdup(argv[i]);
       val = strchr (name, '=');
       if (val == NULL)
        {
-- 
1.5.3.8

signature.asc
Description: OpenPGP digital signature