bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fixes for whitespace in `pwd`


From: Ralf Wildenhues
Subject: Re: fixes for whitespace in `pwd`
Date: Fri, 30 Nov 2007 18:11:47 +0100
User-agent: Mutt/1.5.17 (2007-11-13)

Hi Jim,

* Jim Meyering wrote on Fri, Nov 30, 2007 at 01:48:45PM CET:
> Ralf Wildenhues <address@hidden> wrote:
> > There seems to be at least one more instance, in
> > tests/misc/ls-misc: the command starting with
[...]
> Thanks, Ralf.
> However, that is not a problem, because a check in
> the CuTmpdir module makes us skip the whole test when
> the build directory is suspicious:

Ah ok, thanks for investigating.

>     $ pwd
>     /t/a b/cu

FWIW, I always test with two consecutive spaces.  That helps to catch
eval errors like
  args="'some' 'quoted  args'"
  eval set x $args

where the second line should have rather been something like
  eval set x "$args"

>     $ cd tests/misc && make check TESTS=ls-misc >& /dev/null
>     $ tail -1 ls-misc.log
>     -: skipping test: unsafe working directory name
> 
> Note the "-:" which should be "test_name:".  I've just fixed that, too.]

Good, I wondered a bit about that odd smiley.  ;-)

> In spite of that, I've changed it to add quotes, just in case:

Well, why not.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]