[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: groups --version

From: Jim Meyering
Subject: Re: groups --version
Date: Fri, 31 Aug 2007 23:39:02 +0200

Eric Blake <address@hidden> wrote:
> Jim Meyering <jim <at> meyering.net> writes:
>> Eric Blake-1 <ebb9 <at> byu.net> wrote:
>> > Also, I think it is worth considering a testsuite addition
>> > to ensure the equivalent of:
>> >  diff <(id --version | sed '/^$/q') \
>> >    <(groups --version | sed 's/^groups/id/; /^$/q')
>> > succeeds, but did not do it in this patch.
>> That'd be a fine addition.
>> Patch welcome.
> Here goes.
> 2007-08-31  Eric Blake  <address@hidden>
>       Test yesterday's change to groups.
>       * tests/misc/groups-version: New test.
>       * tests/misc/Makefile.am (TESTS): Sort, and add new test.

I've applied that modulo two things:
  - don't use sed's -e option; not needed
  - don't sort the list of TESTS

I have a pending change that fiddles with that list, and don't
want to induce conflicts.  Eventually, the tests will be ordered
in that list so that some of the longer-running ones appear early
in the list -- then tests run in parallel are better balanced
across multiple cores/threads.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]