bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI, placating valgrind, wrt ./cp --sparse=always


From: Andreas Schwab
Subject: Re: FYI, placating valgrind, wrt ./cp --sparse=always
Date: Thu, 22 Feb 2007 15:33:25 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.91 (gnu/linux)

Jim Meyering <address@hidden> writes:

> diff --git a/src/copy.c b/src/copy.c
> index a3489c3..f0c6539 100644
> --- a/src/copy.c
> +++ b/src/copy.c
> @@ -430,7 +430,8 @@ copy_reg (char const *src_name, char const *dst_name,
>           {
>             char *cp;
>
> -           buf[n_read] = 1;  /* Sentinel to stop loop.  */
> +           wp = (word *) (buf + n_read);
> +           *wp = 1;  /* Sentinel to stop loop.  */

What if n_read is uneven?

Andreas.

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]