bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

fix diagnostic in tests/ls/stat-vs-dirent


From: Paul Eggert
Subject: fix diagnostic in tests/ls/stat-vs-dirent
Date: Mon, 18 Sep 2006 09:37:47 -0700
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)

Here are the symptoms:

./stat-vs-dirent: test failed: /export/duryea: d_ino(42214) != st_ino(2)
./stat-vs-dirent: This may indicate a flaw in your kernel or file system implem\
entation.
./stat-vs-dirent: This flaw won't impact coreutils, but it may well
./stat-vs-dirent: affect other tools,: not found
./stat-vs-dirent: so you should report it to your operating system vendor.
PASS: stat-vs-dirent

The 'not found' is the problem.  Also, the message can be reworded to
be a bit clearer and easy to read.  I installed the following patch,
which changes the symptoms to be as follows:

./stat-vs-dirent: test failed: /export/duryea: d_ino(42214) != st_ino(2)
        This may indicate a flaw in your kernel or file system implementation.
        The flaw isn't serious for coreutils, but it might break other tools,
        so you should report it to your operating system vendor.
PASS: stat-vs-dirent

2006-09-18  Paul Eggert  <address@hidden>

        * tests/ls/stat-vs-dirent: Fix quoting problem in diagnostic
        indicating flaw in kernel.  Reword to say that the flaw isn't
        serious for coreutils, since the flaw does affect ls -i.

--- stat-vs-dirent      17 Aug 2006 19:58:31 -0000      1.3
+++ stat-vs-dirent      18 Sep 2006 16:34:27 -0000      1.4
@@ -60,12 +60,10 @@ while :; do
     # We know from experience that there may be mismatches on some
     # buggy file systems, at mount points.
     if test "$d_ino" != "$st_ino"; then
-      echo "$0: test failed: $t/$file: d_ino($d_ino) != st_ino($st_ino)" 1>&2
-      echo "$0: This may indicate a flaw in your kernel or" \
-            "file system implementation." 1>&2
-      echo "$0: This flaw won't impact coreutils, but it may well"
-            "affect other tools,"
-      echo "$0: so you should report it to your operating system vendor." 1>&2
+      echo "$0: test failed: $t/$file: d_ino($d_ino) != st_ino($st_ino)
+       This may indicate a flaw in your kernel or file system implementation.
+       The flaw isn't serious for coreutils, but it might break other tools,
+       so you should report it to your operating system vendor." 1>&2
 
       # This test fails too often, and we don't want to be distracted
       # with reports, since the code that could be affected by the losing




reply via email to

[Prev in Thread] Current Thread [Next in Thread]