bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils-6.1: needs 'ls' patch (bug #15043)


From: mwoehlke
Subject: Re: coreutils-6.1: needs 'ls' patch (bug #15043)
Date: Fri, 25 Aug 2006 10:14:50 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.5) Gecko/20060719 Thunderbird/1.5.0.5 Mnenhy/0.7.4.0

Mike Frysinger wrote:
On Thursday 24 August 2006 17:03, mwoehlke wrote:
https://savannah.gnu.org/bugs/?func=detailitem&item_id=15043

Is this going to get fixed, or what? There is a trivial fix available,
it just needs someone that knows how to make it 'Linux-only'.

#if __linux__
<foo>
#endif
-mike

Ok, thanks. I a: wasn't sure of a macro that would be defined on Linux (is there a list of these things anywhere? Preferably covering most major platforms?), and b: wasn't sure if people here appreciated such patches.

If #ifdef is OK, this should do it (works for me with 5.97 and 6.1):

*** ls.c.old    2006-08-25 08:10:54.000000000 -0700
--- ls.c        2006-08-25 08:12:49.000000000 -0700
***************
*** 2555,2560 ****
--- 2555,2563 ----

    if (command_line_arg
        || format_needs_stat
+ #ifdef __linux__
+       || (type == directory && print_with_color)
+ #endif
        || (print_inode
          && (inode == NOT_AN_INODE_NUMBER
              /* When dereferencing symlinks, the inode must come from

--
Matthew
'$ time make world' -> real 5d:14h:37m:5.291s user 0m:0.000s sys 4d:2h:14m:43.712s





reply via email to

[Prev in Thread] Current Thread [Next in Thread]