Re: Bug#355368: coreutils: FTBS if SHELL variable is not set

[Jim Meyering]

Sven Joachim <address@hidden> wrote:
> Hello Jim,
>
> thanks for your prompt reply.  I just downloaded the coreutils 6.1
> package from alpha.gnu.org, and it seems this test no longer fails.
> However, there is another dircolors related problem if SHELL is not
> set.  I ran (unset SHELL; make VERBOSE=yes -k check) and noticed the
> following failure:
...
> a...
> -: test a: stderr mismatch, comparing a.E (actual) and a.1 (expected)
> *** a.E       Mon Aug 21 14:02:41 2006
> --- a.1       Mon Aug 21 14:02:41 2006
> ***************
> *** 1 ****
> ! dircolors: no SHELL environment variable, and no shell type option given
> --- 1 ----
> ! dircolors: k:1: invalid line;  missing second token
> quote...
> other-wr...
> FAIL: simple

Thanks for reporting that.
Here's how I've fixed it:

2006-08-21  Jim Meyering  <address@hidden>

        * tests/dircolors/simple (a): Don't fail with an unexpected diagnostic
        when the shell variable, SHELL, is not set.
        Trigger the failure with "(unset SHELL; make check TESTS=simple)".
        Reported by Sven Joachim in <http://bugs.debian.org/355368>.

Index: tests/dircolors/simple
===================================================================
RCS file: /fetish/cu/tests/dircolors/simple,v
retrieving revision 1.11
diff -u -r1.11 simple
--- tests/dircolors/simple      17 Aug 2006 19:58:26 -0000      1.11
+++ tests/dircolors/simple      21 Aug 2006 17:23:45 -0000
@@ -38,7 +38,7 @@
 
 my @Tests =
     (
-     ['a', {IN => {k => "exec\n"}},
+     ['a', '-b', {IN => {k => "exec\n"}},
       {ERR => "dircolors: k:1: invalid line;  missing second token\n"},
       {EXIT => 1}],
      ['quote', '-b', {IN => "exec 'echo Hello;:'\n"},