[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: same-file patch when 'ls' doesn't default to POSIX locale
From: |
Jim Meyering |
Subject: |
Re: same-file patch when 'ls' doesn't default to POSIX locale |
Date: |
Tue, 04 Jul 2006 00:01:12 +0200 |
Eric Blake <address@hidden> wrote:
> According to Jim Meyering on 6/11/2006 2:32 AM:
>> Jim Meyering <address@hidden> wrote:
>>> Thanks for looking into that, but the problem persists
>>> if e.g., TIME_STYLE=long-iso is set in the environment.
>>> I've done this instead:
>>>
>>> 2006-06-11 Jim Meyering <address@hidden>
>>>
>>> Setting TIME_STYLE=long-iso in the environment would make the
>>> cp/same-file test fail.
>>> * tests/envvar-check (vars): Add TIME_STYLE to the list.
>
> Why not also consolidate the two variables POSIXLY_CORRECT and CDPATH from
> evar-check in tests/Makefile.am into envvar-check? I find it annoying
> that I have to run with 'env -uCDPATH make check', when envvar-check could
> do it for me.
I vaguely recall something about $CDPATH being different,
but couldn't find a record of it, and besides, it may well have been
long enough ago that it's no longer relevant.
So I have gone ahead and made this change:
* tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
* tests/Makefile.am (evar-check): Remove rule.
(EXTRA_DIST): Remove .env-warn.
* tests/.env-warn: Remove file. No longer used.
Suggestion from Eric Blake.
If it causes test failures, I'll just revert it and be sure
to document why :)
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: same-file patch when 'ls' doesn't default to POSIX locale,
Jim Meyering <=