Re: coreutils inaccessible test fails on HP-UX with CVS build

[Jim Meyering]

address@hidden (Bob Proulx) wrote:
> Jim Meyering wrote:
>> Here's a patch to skip this test on such systems:
>
> I think that is the best answer.  Because the behavior is known and
> the best that can be done at this time.
>
> The skip test patch worked fine for me to skip the test.  But it was
> too low in the test.  The shell 'trap' is already set and subsequently
> fails on the way out.

Thanks for catching that.
Here's the patch I've applied:

        * tests/rm/inaccessible: Skip this test on systems without openat
        support.  Reported by Bob Proulx.

Index: tests/rm/inaccessible
===================================================================
RCS file: /fetish/cu/tests/rm/inaccessible,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -p -u -r1.4 -r1.5
--- tests/rm/inaccessible       28 May 2006 12:11:35 -0000      1.4
+++ tests/rm/inaccessible       17 Jun 2006 17:46:33 -0000      1.5
@@ -10,6 +10,16 @@ fi
 PRIV_CHECK_ARG=require-non-root . $srcdir/../priv-check
 . $srcdir/../lang-default
 
+# Skip this test if your system has neither the openat-style functions
+# nor /proc/self/fd support with which to emulate them.
+skip=yes
+grep '^#define HAVE_OPENAT' $top_srcdir/config.h > /dev/null && skip=no
+test -d /proc/self/fd && skip=no
+if test $skip = yes; then
+  echo 1>&2 "$0: no openat support, so skipping this test"
+  (exit 77); exit 77
+fi
+
 pwd=`pwd`
 t0=`echo "$0"|sed 's,.*/,,'`.tmp; tmp=$t0/$$
 trap 'status=$?; cd $pwd; chmod -R u+rwx $t0; rm -rf $t0 && exit $status' 0
@@ -30,7 +40,6 @@ fail=0
 p=$pwd/$tmp
 set +x
 (cd no-access; chmod 0 . && rm -r $p/abs1 rel $p/abs2) 2> out && fail=1
-test "$VERBOSE" = yes && set -x
 test -d $p/abs1 && fail=1
 test -d $p/abs2 && fail=1