bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils-5.96 doesn't build (out of the box)


From: Ralf Wildenhues
Subject: Re: coreutils-5.96 doesn't build (out of the box)
Date: Wed, 31 May 2006 11:44:49 +0200
User-agent: Mutt/1.5.11

Hi Paul,

* Paul Eggert wrote on Wed, May 31, 2006 at 10:20:56AM CEST:
> Ralf Wildenhues <address@hidden> writes:
> 
> > +[if (as_dir=`dirname -- /` && test "$as_dir" = /) >/dev/null 2>&1; then
> 
> Surely that should be
> 
>   test "X$as_dir" = X/
> 
> in case $as_dir is "--" or something worse...

*blush*...

I've applied this.  Thanks for spotting!

Cheers,
Ralf

        * lib/m4sugar/m4sh.m4 (_AS_DIRNAME_PREPARE): Guard against test
        argument with leading hyphen.  Problem reported by Paul Eggert.

Index: lib/m4sugar/m4sh.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/m4sugar/m4sh.m4,v
retrieving revision 1.189
diff -u -r1.189 m4sh.m4
--- lib/m4sugar/m4sh.m4 30 May 2006 23:24:55 -0000      1.189
+++ lib/m4sugar/m4sh.m4 31 May 2006 09:42:37 -0000
@@ -755,7 +755,7 @@
 # _AS_DIRNAME_PREPARE
 # --------------------
 m4_defun([_AS_DIRNAME_PREPARE],
-[if (as_dir=`dirname -- /` && test "$as_dir" = /) >/dev/null 2>&1; then
+[if (as_dir=`dirname -- /` && test "X$as_dir" = X/) >/dev/null 2>&1; then
   as_dirname=dirname
 else
   as_dirname=false




reply via email to

[Prev in Thread] Current Thread [Next in Thread]