bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

tests/dd/misc patch for typo in noatime test


From: Paul Eggert
Subject: tests/dd/misc patch for typo in noatime test
Date: Wed, 08 Mar 2006 10:23:22 -0800
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

I installed this patch which I caught by code inspection (I don't have
easy access to a kernel with the noatime feature):

2006-03-08  Paul Eggert  <address@hidden>

        * tests/dd/misc: iflags->iflag.  This fixes a typo that meant the
        noatime test never tested anything.

--- tests/dd/misc       9 Dec 2005 21:52:50 -0000       1.4
+++ tests/dd/misc       8 Mar 2006 18:11:55 -0000
@@ -1,6 +1,6 @@
 #!/bin/sh
 # Ensure dd treats `--' properly.
-# Also ensure that iflags=noatime works.
+# Also ensure that iflag=noatime works.
 
 tmp_in=dd-in.$$
 tmp_out=dd-out.$$
@@ -26,10 +26,10 @@ cmp $tmp_in $tmp_out || fail=1
 
 old_ls=`ls -u --full-time $tmp_in`
 sleep 1
-if dd iflags=noatime if=$tmp_in of=$tmp_out > /dev/null 2>&1; then
+if dd iflag=noatime if=$tmp_in of=$tmp_out > /dev/null 2>&1; then
   new_ls=`ls -u --full-time $tmp_in`
   if test "x$old_ls" != "x$new_ls"; then
-    echo "dd iflags=noatime updated atime; O_NOATIME bug in your kernel?" >&2
+    echo "dd iflag=noatime updated atime; O_NOATIME bug in your kernel?" >&2
     fail=1
   fi
 fi




reply via email to

[Prev in Thread] Current Thread [Next in Thread]