[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bugs in dirname module - coreutils portion

From: Jim Meyering
Subject: Re: bugs in dirname module - coreutils portion
Date: Wed, 30 Nov 2005 14:47:52 +0100

Eric Blake <address@hidden> wrote:
> OK, I will do better at not combining whitespace cleanup with real
> patches.  And I agree with your comment that using diff -b as a crutch is
> not wise, so here is the updated patch with no whitespace filtering.

Thanks for the big patch -- and for your patience.

I've been holding off because I don't want this to interfere with
the pending patch to add ACL support.  Since I've made Andreas wait
for so long (it's been years), the least I can do is to defer a
patch like this, so as not to make his job any harder.
It might be one week more.

One question: why continue to use base_name in rm.c, rather than
converting that use to last_component, the way you did in all of
the other cases?

> Index: src/rm.c
> ===================================================================
> RCS file: /cvsroot/coreutils/coreutils/src/rm.c,v
> retrieving revision 1.136
> diff -u -p -r1.136 rm.c
> --- src/rm.c  2 Nov 2005 21:53:20 -0000       1.136
> +++ src/rm.c  25 Nov 2005 15:00:21 -0000
> @@ -169,6 +169,7 @@ the contents of that file.  If you want
>  truly unrecoverable, consider using shred.\n\
>  "), stdout);
>        printf (_("\nReport bugs to <%s>.\n"), PACKAGE_BUGREPORT);
> +      free (base);
>      }
>    exit (status);
>  }

reply via email to

[Prev in Thread] Current Thread [Next in Thread]